| Issue 1885: | Can't open diff with "show line endings" disabled | |
| 12 people starred this issue and may be notified of changes. | Back to list |
Affected Version: 2.6-RC1 What steps will reproduce the problem? 1. Disable "Show line endings" 2. Try to view diff of a certain file (this issue does not affect all our repos or all files, it is most possibly related to different line-endind settings) What is the expected output? What do you see instead? Expected diff to be opened, but gerrit simply does not navigate to the diff and stays on the same page. Please provide any additional information below. Logs does not contain anything useful. I can't share company's private repositories, but I will provide any data that doesn't contain large chunks of our source code.
Apr 24, 2013
#1
sop@google.com
Labels:
Blocking-2.6
Apr 25, 2013
(No comment was entered for this change.)
Status:
CannotReproduce
May 16, 2013
this is a major issue for our company with 2.5.1. It took us weeks to find out that this option causes the "random" failure.
May 17, 2013
I can't reproduce it, and I don't have enough detail to deduce a cause and write an attempted fix. So CannotReproduce is the right status.
May 18, 2013
It happens quite frequently in our heterogenous environment. It seems to be related to files being converted from one line ending style to the other. Whe showingnline endings is off, i simply cannot open the diff...
May 19, 2013
>I can't reproduce it, and I don't have enough detail to deduce a cause and write an attempted fix. >So CannotReproduce is the right status. Hi! Maybe you can give my some insight from which class/method to trace execution? I'm still willing to invest some time to debug it locally :)
May 19, 2013
I can't, if you meant me :) there is zero information in the logs...
Jun 8, 2013
Firebug logs the following error to the console. Any ideas?
uncaught exception: Class$S1625: Array index 374 out of range
function yMb(){try{null.a()}catch(a){return a}}
I don't know if it is related somehow to the fact that server still includes line endings in the JSON response even if showing them in diff is disabled.
Jun 10, 2013
Give ?dbg=1 a try https://groups.google.com/forum/?fromgroups#!topic/repo-discuss/Mv2gAHnf-kI
Jun 12, 2013
I also have run into this bug using 2.6-RC3. Using ?dbg=1 the stacktrace gives the following function as the one causing the error:-
(line 55296 in the stack trace)
function entry_0(jsFunction){
return function(){
try {
return entry0(jsFunction, this, arguments);
}
catch (e) {
throw e;
Uncaught Class$S1760: Array index 1289 out of range
}
}
;
}
Full stacktrace attached.
If it helps to reproduce, all our code files use Windows line endings and git is set to preserve them.
Jun 24, 2013
Issue 1904 has correct reproduce steps.
Jul 23, 2013
Seems to me as if this issue is not fixed with 2.6.1. Show line endings = Disabled => Index out of array exception (in many files) Show line endings = Enabled => Diff can be shown.
Aug 29, 2013
I can also confirm that this is still an issue in 2.6.1 final. The proposed workaround by showing line endings solves the problem. It would be good to be able to turn on/off displaying line endings.
Oct 4, 2013
Present in 2.7-rc3 as well
Nov 3, 2013
Met with Shawn at EclipseCon Europe last week and demonstrated the issue. From what he said, it seems that the problem is somewhere in the syntax highlighting. The browser's log shows an exception in an anonymous function (unfortunately) accessing an array index 73 (for a file having 72 lines!). So: this only happens when hitting an affected file with show line endings OFF and syntax highlighting ON. I unfortunately still don't know how to get an "affected file" ;) |
|
| ► Sign in to add a comment |