My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1863: Arial Unicode MS doesn't come in bold, consider using a different default font
2 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  sop@google.com
Closed:  Aug 2013
Cc:  dsand...@google.com


Sign in to add a comment
 
Reported by dsand...@google.com, Apr 11, 2013
Affected Version:2.6

What steps will reproduce the problem?
1. Visit "My Reviews" in Chrome on a Mac with the "Arial Unicode MS" font installed
2. Look at the rows, note that they are subtly but inexplicably different

Apparently the rows that need review (class="needsReview") are supposed to be bold, but since Arial Unicode MS does not *have* a bold variant, those rows…do something else. I'm not sure if Chrome is attempting fake bold or failing over to the default font or what, but it looks awful.

Recommend that the default typeface (looks like norm-font in gerrit.css?) be set to Arial, or even simply "sans-serif" to pick up the user's default.

Screenshots:
- Current behavior, rendering Arial Unicode MS strangely in rows that are supposed to be bold
- Same region of webpage, but with "Arial Unicode MS" removed from the CSS manually via Chrome's inspector
Screen Shot 2013-04-11 at 2.39.10 PM.PNG
35.6 KB   View   Download
Screen Shot 2013-04-11 at 2.41.53 PM.PNG
30.7 KB   View   Download
Apr 11, 2013
#1 dsand...@google.com
Looks like maybe https://gerrit.googlesource.com/gerrit/+/13fe99a2fc0dd1ec300116ae7fbe16d7cc068979 is where that font was introduced? Shawn?
Apr 11, 2013
#2 sop@google.com
Seems like it. _No_ clue why I used that font name.

Its "just" CSS. I take it you are suggesting we modify to sans-serif?
Status: Accepted
Owner: sop@google.com
Apr 11, 2013
#3 dsand...@google.com
I think that would work, yes.

(We could consider using the Roboto webfont for r.android.com…)
Apr 17, 2013
#4 sop@google.com
https://gerrit-review.googlesource.com/44721
Status: ChangeUnderReview
Apr 22, 2013
#5 sop@google.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.7
Jun 13, 2013
#6 jykni...@google.com
This change was not sufficient, this bug has not actually been fixed. Despite there being no mention of Arial Unicode MS left in gerrit itself, the first stanza in the generated css file says:

body, table td, select {
  font-family: Arial Unicode MS, Arial, sans-serif;
  font-size: small;
}

And the originally observed problem remains. It looks like that's coming from gwt's default stylesheet (which seems crazy; why would gwt do that to its users?)
Jun 13, 2013
#7 dsand...@google.com
I just today happened to check the CSS in my client and saw the Aerial
Unicode reference. I simply assumed that the patch hadn't been rolled out
in my organization's Gerrit instance.
Aug 21, 2013
#8 sop@google.com
dsandler reports this is still an issue.
Status: AwaitingInformation
Cc: dsand...@google.com
Aug 21, 2013
Project Member #9 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Submitted
Labels: -FixedIn-2.7 FixedIn-2.8
Dec 9, 2013
Project Member #11 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Released
Jan 2, 2014
#12 Ning.N.J...@gmail.com
There is a minor issue with this fix https://gerrit-review.googlesource.com/49070. Previously I have "Arial Unicode MS" by default when browsing with Chrome. But now I have to change the font setting manually in the browser after migrating from 2.7 to 2.8. This is somewhat inconvenient as we have hundreds of developers in our org and they starts to complaint about this font change.

Can I have a way to keep the default "Arial Unicode MS" without setting font in Chrome?
Sign in to add a comment

Powered by Google Project Hosting