| Issue 1861: | REST api for .../{revision}/review should return approvals for the specified revision | |
| 10 people starred this issue and may be notified of changes. | Back to list |
Why does it always return approvals for the latest revision? Is there a way to retrieve approvals for previous revisions? I need it for the trivial_rebase script.
May 20, 2013
Project Member
#1
david.pu...@sonymobile.com
Jul 8, 2013
No, that doesn't fix it: unless there's some undocumented syntax to use ?o=ALL_REVISIONS for review requests (which I didn't find with some guesswork), that's just for querying changes. https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#list-changes I agree with the reporter that this would be a useful feature: currently the API wouldn't add anything to a clone including refs/notes/review. This has some intersection with https://code.google.com/p/gerrit/issues/detail?id=1567 , which would allow to do some things via queries.
Jul 8, 2013
On the other hand, you can do <https://gerrit-review.googlesource.com/changes/?q=I8d2cefb1e7bb9d12609bb0c2ef1b08105cc040d9&o=ALL_REVISIONS&o=LABELS&o=DETAILED_LABELS>
Jul 8, 2013
This still shows only the latest labels (you don't see Dave's -1 for patch set 1)
Jun 26, 2014
(No comment was entered for this change.)
Status:
Accepted
Owner: zaro0508
Jul 3, 2014
This REST endpoint definitely doesn't work as expected. I posted to the gerrit mailing list [1] to get clarification, no reply yet :( I think the problem is that older patchset's votes are not saved so gerrit would need the ability to keep a history of votes and comments for each revision/patchset of a change before this REST endpoint can return info on a specific revision. [1] https://groups.google.com/d/msg/repo-discuss/rhJR_ondcjE/sJxHlekOPX4J
Owner:
---
|
|
| ► Sign in to add a comment |