My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 186: Add "Reply" button to existing comments in a review
  Back to list
Status:  Released
Owner:  code-rev...@gtempaccount.com
Closed:  Oct 2012


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Mike LeBeau <mlebeau@android.com> on Thu May 21 12:05:59 PDT 2009
Source: JIRA GERRIT-186
Affected Version: 2.0.12

It would be great if, instead of having to create a second comment on the same
line of code, it were possible as in Mondrian to "Reply" to an individual
comment. This should also have the benefit of quoting the original comment in
the generated email rather than quoting the line of code again, making a
conversation within gerrit easier.

(Shawn I searched and could not find a similar request so I hope this isn't a
dupe. :))
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Sun Jun 07 16:29:11 PDT 2009

Does Mondrian hard line wrap the quoted text?

One concern I have right now is Gerrit doesn't insert line wrap on long
paragraphs, it just allows the browser to reflow the text to fit the space
available.  Thus there are usually only LFs in the raw message text where the
author inserted paragraph breaks.

Sounds like I'd have to hard line wrap the original message at ~70 characters,
and insert "> " or something to denote the quoting, but then this will likely
break the way the formatter converts the plain text to HTML, as I'd need to
inject a <br> at every "\n> " to ensure it stays line wrapped when
displaying.  But this is also likely to confuse the preformat parser, which
scans for leading whitespace on a line.

Hmm.
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Fri Jul 10 09:46:57 PDT 2009

Assigned to Cedric Beust.
Sep 24, 2009
#3 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Sat Jul 18 18:14:15 PDT 2009

Fixed by https://review.source.android.com/10528
Sep 24, 2009
#4 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Sat Jul 18 18:14:15 PDT 2009

Fixed in version 2.0.17.
Status: Fixed
Sep 25, 2009
#5 code-rev...@gtempaccount.com
(No comment was entered for this change.)
Labels: FixedIn-2.0.17
Oct 25, 2012
#6 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting