My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1848: Hitting escape while entering code review feedback throws away input
2 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Apr 2013


Sign in to add a comment
 
Reported by emun...@mgebm.net, Mar 29, 2013
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version:

What steps will reproduce the problem?
1. While reviewing a specific file, write comments about a single line
2. Hit escape
3. Watch your work disappear

What is the expected output? What do you see instead?
At worst it should save the comments as a draft, better would be to do nothing.

Please provide any additional information below.
For vi/vim users the Esc key is muscle memory, having it throw away everything that was entered is incredibly frustrating.

Apr 4, 2013
Project Member #1 david.pu...@sonymobile.com
https://gerrit-review.googlesource.com/#/c/44291/
Status: ChangeUnderReview
Apr 7, 2013
Project Member #2 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.7
Sep 20, 2013
Project Member #3 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting