My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 184: Make keyboard shortcuts that bring up a new window act more like toggles
  Back to list
Status:  Released
Owner:  code-rev...@gtempaccount.com
Closed:  Oct 2012


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Zach Wily <zach@zwily.com> on Thu May 21 08:56:41 PDT 2009
Source: JIRA GERRIT-184
Affected Version: 2.0.12

The expanded keyboard shortcuts are great, but I find myself bringing up the
help window often with '?' and then having to navigate to the Close link with
the mouse. It'd be really nice if the window closed with a second press of '?'.

This applies to the filelist browser too. That one you have to hit escape on
to get rid of. Toggling with 'f' would be awesome.
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Thu May 21 09:17:59 PDT 2009

I agree, 'f' in the file browser as a toggle is a really good idea, I'll get
it added soon.

The help window, '?', should close with *any* keystroke, and if the keystroke
has a binding, the binding is executed immediately.  So '?', will open the
help dialog, pressing '/' will close it, and will immediately focus to the
search box.  Thus '?' in the help window is actually causing the window to
close, and the immediately reopen, but its all occurring in the same browser
event so the user never sees UI flicker.  :-)

I'll add a '?' when inside of the help dialog to actually close the help
dialog.  That may be a bit trickier to do, the help dialog doesn't process
keyboard events.
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Thu May 21 11:56:30 PDT 2009

Fixed in version 2.0.13.
Status: Fixed
Sep 24, 2009
#3 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Thu May 21 11:56:30 PDT 2009

Fixed by https://review.source.android.com/10034
Sep 25, 2009
#4 code-rev...@gtempaccount.com
(No comment was entered for this change.)
Labels: FixedIn-2.0.13
Oct 25, 2012
#5 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting