My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1830: Inline commit message editor should normalise carriage return to line feed
4 people starred this issue and may be notified of changes. Back to list
Status:  Submitted
Owner:  ----
Closed:  Mar 2013


Sign in to add a comment
 
Reported by krinklemail@gmail.com, Mar 18, 2013
Affected Version: 2.5.2-1636-g353e384

What steps will reproduce the problem?
1. Use Internet Explorer to edit a commit message that has proper line feeds
2. Save it

What is the expected output? What do you see instead?
The lines that weren't intentionally changed should still be the same. And ideally any line breaks added by simply pressing the Return/Enter key should also not result in carriage returns (CR \r instead of LF \n).

The main reason this is a problem (though that is perhaps a separate bug) is that the logic used to extract the subject from the commit message ("the first line(s) before the first empty line separating it from the body text") only looks for \n, not \r. As a result, a commit message with carriage returns will be output on 1 long line.

Please provide any additional information below.

- Diff
https://gerrit.wikimedia.org/r/#/c/52439/1..2//COMMIT_MSG

- Rendering
https://gerrit.wikimedia.org/r/#/c/52439/2
The rendering of the text is also wrong. It appears \r is rendered as two line breaks instead of one (\n and <br> inside <pre>)

- Subject extraction
https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/ConfirmEdit+topic:de/captcha,n,z

In list view, the entire commit message (instead of just the first line(s) upto the first empty line) is used and trimmed.

It says "Remove german special page alias for 'Captcha'   The translation is wrong, ... (Merged)"
instead of "Remove german special page alias for 'Captcha' (Merged)".

The second paragraph shouldn't be used and there shouldn't be an ellipsis.


Downstream issue: https://bugzilla.wikimedia.org/45802
return.png
476 KB   View   Download
Mar 18, 2013
#1 i.d.rath...@gmail.com
The fix at

https://gerrit-review.googlesource.com/#/c/43582/

worked for me on IE8 on Windows XP.
Mar 18, 2013
#2 sop@google.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.6
Sign in to add a comment

Powered by Google Project Hosting