My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1802: Create reference access allows user to push through unreviewed commits
15 people starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Reported by hughdave...@gmail.com, Feb 24, 2013
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version: 2.5.2

What steps will reproduce the problem?
1. Grant a user create reference
2. That user creates a new local branch based on an existing branch
3. That user creates a *new* commit
4. That user pushes, no errors occur

What is the expected output? What do you see instead?
I would expect that a new commit shouldn't be allowed in the create reference. It should only allow creating a new reference with a known commit

Please provide any additional information below.
The workflow we use is as follows
1. git checkout -b bug/xxx origin/prod
2. git push origin bug/xxx (create a new branch)
3. commit
4. git push origin HEAD:refs/for/bug/xxx
This problem occurs when step 2 is swapped with step 3 accidentally.
Feb 24, 2013
#1 hughdave...@gmail.com
What would be good is having an access right to create reference and push to review all new changes if a branch doesn't exist.

So if I push to refs/for/bug/xxx and bug/xxx doesn't exist, it is automatically created on the oldest branch
Jul 17, 2013
#2 Brian.Pr...@gmail.com
IMHO the priority of this bug is way to low!
Nov 11, 2014
#3 angus...@gmail.com
This problem really trouble us a lot! 
If we grant a user "create reference" right, he/she prone to push un-reviewed commits accidentally when he/she working on his/her local branch.

If we would like user can create remote branch himself but all commits should be reviewed, does anyone have other suggestion what's the access setting should we set?
Jul 8, 2015
#4 zindagir...@gmail.com
Do we have a solution to this ?

We want user to be capable of creating the branches, but don't want them to push their code along with new branch.
Sign in to add a comment

Powered by Google Project Hosting