My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 179: Display images in gerrit diffs
  Back to list
Status:  Released
Owner:  code-rev...@gtempaccount.com
Closed:  Oct 2012


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Mike LeBeau <mlebeau@android.com> on Fri May 15 11:17:05 PDT 2009
Source: JIRA GERRIT-179
Affected Version: 2.0.11

Would be great if gerrit were able to show images (and possibly even other
media types like audio) when diffing such files, rather than just "binary
files differ".
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Fri May 15 11:22:01 PDT 2009

Images opens a nasty problem with cross site scripting attacks and buffer
overflows in browser clients.

But, if the site is pretty restricted on access (e.g. inside a corporate
firewall) then showing images is probably reasonable, as users can most likely
be trusted to upload reasonable image files, and if not, its logged accurately
enough to have a friendly discussion with the culprit.
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Fri May 15 11:22:45 PDT 2009
Blockedon: 139
Sep 24, 2009
#3 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Tue May 26 15:59:49 PDT 2009

Assigned to Cedric Beust.
Sep 24, 2009
#4 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Wed Jul 15 09:05:27 PDT 2009

Fixed by https://review.source.android.com/10275
Sep 24, 2009
#5 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Wed Jul 15 09:05:27 PDT 2009

Fixed in version 2.0.17.
Status: Fixed
Sep 25, 2009
#6 code-rev...@gtempaccount.com
(No comment was entered for this change.)
Labels: FixedIn-2.0.17
Oct 25, 2012
#7 sop@google.com
(No comment was entered for this change.)
Status: Released
Blockedon: -gerrit:139
Jul 4, 2013
#8 annu...@gmail.com
Images disappeared after upgrade to Gerrit 2.6.1
Sign in to add a comment

Powered by Google Project Hosting