My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1778: Reviewers mail contains name of the first reviewer
2 people starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Reported by christop...@gmail.com, Feb 6, 2013
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version: 2.5.1

What steps will reproduce the problem?
1. Upload a patch to be reviewed.
2. Have Jenkins (the build server) as first reviewer. In our case Jenkins does not have an email address.
3. Add a second reviewer (e.g. John Doe <john.doe@example.com>).
4. Upload another patch set.

John will now receive an email beginning with 
"Hello Jenkins,

I'd like you to reexamine a change.  Please visit..."

while we expect him to get a mail like 

"Hello John Doe,

I'd like you to reexamine a change.  Please visit..."

This is a bit of a problem because some of us use the mail content to sort the mail and set importance...
Feb 13, 2013
Project Member #1 david.pu...@sonymobile.com
I think this is the intended/expected behaviour.  Gerrit only sends one mail to all reviewers, rather than sending each reviewer an individual mail.
Feb 13, 2013
#2 christop...@gmail.com
As I pointed out this might lead to problems when filtering the messages by the content. Also it is confusing to get a mail which seems to be intended for smb else.
Sign in to add a comment

Powered by Google Project Hosting