My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1734: Intraline Difference hides underscore character in multiline
5 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Feb 2015


Sign in to add a comment
 
Reported by thomas.f...@gmail.com, Dec 19, 2012
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version: 2.4.2-3-g96f9793

What steps will reproduce the problem?

In the review window, if a line is long and is shown as a multiline, and "Intraline Difference" is enabled, this will hide any underline characters (_) in lines above the "Intraline Difference" marking.

E.g:
     123 This is a long line using_between_some_words
         and is divided into several lines

If the last part is marked with "Intraline Difference" (darker green),
the underscore characters in the line above is not shown:

E.g:
This character is not shown   ----+
                                  v
     123 This is a long line using between_some_words
         and is divided into several lines

What is the expected output? What do you see instead?

I would have expected the characters to be shown even if changes are
marked with "Intraline Difference"

Please provide any additional information below.
Feb 17, 2015
Project Member #1 zaro0508
We also saw this problem in Gerrit 2.8 but only when using the new change screen.  I have tested with Gerrit 2.9.4 and don't see the problem anymore (with either old OR new screen).  It must have been fixed somewhere in between those releases.
Status: Released
Sign in to add a comment

Powered by Google Project Hosting