My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1725: Ignore whitespace in Gerrit does the opposite of what you select?
2 people starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Reported by Kent.Wen...@gmail.com, Dec 14, 2012

Affected Version: 2.3+ (possibly others as well)

What steps will reproduce the problem?
1.
Open a text file with whitespace errors for review (diff) in Gerrit. 
(see attached image)
2.
Click preferences.
3.
Set Ignore whitespace drop down to either All or None.
4.
Observe the effect by clicking update. 

What is the expected output? What do you see instead?

I would expect that "Ignore whitespace: All" would ignore all whitespace.
Instead it shows all whitespace.
Conversely selecting "Ignore whitespace: None" I'd expect to show all 
whitespace instead it ignores (hides) all whitespace.

This seems completely backwards and will confuse users.

Please provide any additional information below.

Attached image shows the issue. The image has been obfuscated to not 
show any actual code due to policy but it still provide enough info to
see the issue.
Gerrit_reverse_whitespace.png
57.8 KB   View   Download
Sign in to add a comment

Powered by Google Project Hosting