My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1701: NPE in CherryPick during /submit or /revert
2 people starred this issue and may be notified of changes. Back to list
Status:  CannotReproduce
Owner:  ----
Closed:  Dec 2013


Sign in to add a comment
 
Project Member Reported by sop@google.com, Dec 3, 2012
We are seeing NPEs from /submit or /revert. Stack trace is slightly old as its from 3ed1fc0.

Line 179 is:
  ps.setUploader(submitAudit.getAccountId());

So the submitAudit record didn't exist when the API call was made. Its a bit unclear what we are supposed to do in this case, since its a submit request it probably should be failing hard and there may be another issue about not having a SUBM approval on the change?

java.lang.NullPointerException:
at com.google.gerrit.server.git.CherryPick.writeCherryPickCommit(CherryPick.java:179)
at com.google.gerrit.server.git.CherryPick._run(CherryPick.java:98)
at com.google.gerrit.server.git.SubmitStrategy.run(SubmitStrategy.java:99)
at com.google.gerrit.server.git.MergeOp.preMerge(MergeOp.java:383)
at com.google.gerrit.server.git.MergeOp.merge(MergeOp.java:288)
at com.google.gerrit.server.git.ChangeMergeQueue$2.call(ChangeMergeQueue.java:207)
at com.google.gerrit.server.git.ChangeMergeQueue$2.call(ChangeMergeQueue.java:204)
at com.google.gerrit.server.util.RequestScopePropagator$5.call(RequestScopePropagator.java:211)
at com.google.gerrit.server.util.RequestScopePropagator$4.call(RequestScopePropagator.java:190)
at com.google.gerrit.server.git.PerThreadRequestScope$Propagator$1.call(PerThreadRequestScope.java:75)
at com.google.gerrit.server.git.ChangeMergeQueue.mergeImpl(ChangeMergeQueue.java:204)
at com.google.gerrit.server.git.ChangeMergeQueue.merge(ChangeMergeQueue.java:124)
at com.google.gerrit.server.change.Submit.apply(Submit.java:116)
at com.google.gerrit.server.change.Submit.apply(Submit.java:53)
at com.google.gerrit.httpd.restapi.RestApiServlet.service(RestApiServlet.java:234)
Dec 3, 2012
Project Member #1 bruce.zu@sonymobile.com
Gerrit version?
Dec 3, 2012
Project Member #2 edwin.ke...@gmail.com
Must be current master since /submit and /revert are not available in other versions. Likely it is 2.5-698-g60cf885 which is currently running on gerrit-review.googlesource.com.
Dec 4, 2012
#3 sop@google.com
Actually I found the stack trace in a binary built from 3ed1fc0, which is what we had on android-review up until yesterday evening when I upgraded it to 2.5-698-g60cf885.

So yes, master. A pretty recent master. There was a change in CherryPick.java that shifted the line numbers slightly between these two commits, but this change does not impact the NPE failure.

I saw a few failures with this trace from both /submit and /revert. /submit might be something else, like a missing SUBM record that should have existed but doesn't. /revert... can you revert something that isn't submitted?
Dec 4, 2012
Project Member #5 edwin.ke...@gmail.com
Oh no, this seems to be a different NPE :(
Dec 12, 2013
#6 sop@google.com
I think this was fixed. We aren't seeing in anymore.
Status: CannotReproduce
Sign in to add a comment

Powered by Google Project Hosting