My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 170: Permit PatchDetailService patchScript to be cached by browsers, proxies
  Back to list
Status:  WontFix
Owner:  code-rev...@gtempaccount.com
Closed:  Sep 2009


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Shawn Pearce <sop@google.com> on Thu May 07 20:42:44 PDT 2009
Source: JIRA GERRIT-170
Affected Version: 2.0.11

Now that the static information is returned by patchScript we can switch this
to use an HTTP GET request and permit browsers and proxies to cache the
content, rather than fetching it over and over again each time the user views
the file.

The benefit of this caching isn't really known; we stream the response back
pretty rapidly as it is, and in cases where the change isn't visible to
Anonymous Users we may still need to require HTTP POST, XSRF keys, and no-
caching headers, to ensure the user is authorized to view the content.
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Mon Jun 08 18:47:55 PDT 2009

This is harder now due to the patch script taking the user's drafts into
account when it renders, as the context around the draft message must be
included even if the draft itself isn't published and isn't near any other
edit region.  The safe approach is to just never cache it.
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Mon Jun 08 18:47:55 PDT 2009
Status: WontFix
Sign in to add a comment

Powered by Google Project Hosting