| Issue 1692: | Comments listed out of order in email | |
| 1 person starred this issue and may be notified of changes. | Back to list |
Affected Version: 2.5-638-g62a5324 (https://gwt-review.googlesource.com) I added comments to https://gwt-review.googlesource.com/#/c/1290/ and the email I received listed the comments out of order (i.e., line 179 before line 48). I'd expect the comments to be in line order. I'm pretty sure I added the comment on line 48 before adding the comment on line 179 even, but I did add a comment somewhere in between that I ended up deleting. From: Matthew Dempsky <noreply-gerritcodereview-C9SQgEEQipHAztdAtGX8zg@google.com> Date: Thu, Nov 29, 2012 at 9:28 AM Subject: Change in gwt[master]: Remove dependency from GWT-JUnit on deRPC To: Thomas Broyer <xxx@gmail.com> Cc: Matthew Dempsky <mdempsky@google.com> Matthew Dempsky has posted comments on this change. Change subject: Remove dependency from GWT-JUnit on deRPC ...................................................................... Patch Set 1: (2 inline comments) .................................................... File user/src/com/google/gwt/junit/server/JUnitHostImpl.java Line 179: private String getRequestModuleBasePath() { Would it make sense to move this into AbstractRemoteServiceServlet instead to avoid the code duplication? Line 48: * An RPC servlet that serves as a proxy to JUnitTestShell. Enables Since JUnitHostImpl no longer extends RpcServlet, should this comment be updated to "A remote service servlet that ..."? -- To view, visit https://gwt-review.googlesource.com/1290 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74c9d2e339187c2a47ccea4b0082c3a59ffe5ae4 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer <xxx@gmail.com> Gerrit-Reviewer: Matthew Dempsky <mdempsky@google.com> Gerrit-HasInlineComments: Yes
Nov 29, 2012
#1
sop@google.com
Status:
Accepted
Nov 29, 2012
(No comment was entered for this change.)
Owner:
sop@google.com
Nov 29, 2012
Change submitted upstream. Build is running now. I will try to deploy it within the next couple of hours.
Status:
Submitted
Labels: FixedIn-2.6
Nov 29, 2012
Deployed for MTV folks. Rest of the world will have it soon.
Status:
Released
Nov 29, 2012
Cool, I'll watch for this then. Thanks for the quick fix! |
|
| ► Sign in to add a comment |