My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1675: Administrator doesn't have control over drafts
1 person starred this issue and may be notified of changes. Back to list
Status:  Submitted
Owner:  ----
Closed:  Dec 2012


Sign in to add a comment
 
Reported by hughdave...@gmail.com, Nov 21, 2012
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version:

What steps will reproduce the problem?
1. User A creates a draft patch sees "Review/Delete Draft Change/Rebase Change/Publish/Diff All Side-by-Side/Diff All Unified"
2. Administrator can't view at all 
3. If User A adds the Adminstrator to the patch, then administrator can only see "Review/Rebase Change/Diff All Side-by-Side/Diff All Unified" (ie no publish button)

What is the expected output? What do you see instead?
I would expect that the adminstrator would be able to view the draft change by default, and have full control over it.
If it is deemed that they shouldn't see it by default, they should atleast get control over it if the owner adds them to the reviewers list so they can publish it if that user dissapears from community)

Please provide any additional information below.

Nov 21, 2012
Project Member #1 david.pu...@sonymobile.com
> Administrator can't view at all

This is fixed in #1585
Ability to view drafts is now a grantable permission.  By default the administrator does not have it, but can be added

Status:
Nov 21, 2012
Project Member #2 david.pu...@sonymobile.com
Oops, it looks like I accidentally removed the status when I added my previous comment.
Status: New
Nov 21, 2012
#3 hughdave...@gmail.com
Hey David,

I see that your patch https://gerrit-review.googlesource.com/#/c/39131/2 went in just after the 2.5 release xD.

This could be useful for us though, so I may cherry-pick this back and build it ;)

I would say this can be closed now.

Cheers,

Hugh
Nov 21, 2012
#4 hughdave...@gmail.com
Hey David,

Just tested this, but it doesn't allow a way of changing (ie deleting or publishing) a draft change, only viewing it when not on the reviewers list. Do you know if anything has gone through for that?

Cheers,

Hugh
Dec 11, 2012
Project Member #5 david.pu...@sonymobile.com
Sorry for the late reply.  For some reason I am not getting notifications of new comments.

I don't think admins should by default be allowed to delete or publish a draft.  According to the access control documentation:

  Membership in the 'Administrators' group does not imply any other
  access rights.  Administrators do not automatically get code review
  approval or submit rights in projects.  This is a feature designed
  to permit administrative users to otherwise access Gerrit as any
  other normal user would, without needing two different accounts.

So I think it would be better to add new permission settings that can be applied to the admin group.  That would work in the same way as "can view drafts".

Dec 11, 2012
Project Member #6 david.pu...@sonymobile.com
Change uploaded for review:  https://gerrit-review.googlesource.com/#/c/40434/

Status: ChangeUnderReview
Dec 12, 2012
Project Member #7 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.6
Sign in to add a comment

Powered by Google Project Hosting