My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1668: Show "Needed By" Abandonded patches in red
2 people starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Reported by hughdave...@gmail.com, Nov 19, 2012
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version:

What steps will reproduce the problem?
1. Submit 2 patches, one which depends on the other
2. Abandon top patch
3. See that the Needed by list has the abandoned patch in normal colour

Note, I found this bug with more than one "Needed by" patches, but didn't have time to reproduce it more with just one. Only one of the many were abandoned.

What is the expected output? What do you see instead?
I would expect it to be coloured red instead of white. The "Depends on" shows red

Please provide any additional information below.

Nov 19, 2012
#1 hughdave...@gmail.com
I lie, I did have time. If only one patch is in the Needed by (or probably multiple but all are abandoned), it is hidden by default, but the colour is still wrong
Nov 20, 2012
Project Member #2 david.pu...@sonymobile.com
The "Depends On" is shown in red because it's something that will prevent the change from being submitted.

In the case of "Needed By" though, it does not prevent the current change from being submitted.  Therefore it is not shown in red.

I would say that the current behaviour is correct, not a bug.
Sign in to add a comment

Powered by Google Project Hosting