My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1608: When rejecting commits with missing Change-Id, suggest where to get the commit-msg hook
4 people starred this issue and may be notified of changes. Back to list
Status:  Submitted
Owner:  ----
Closed:  Oct 2012


Sign in to add a comment
 
Reported by mdemp...@google.com, Oct 15, 2012
Affected Version: 2.5-rc0-127-g1ba65ac

What steps will reproduce the problem?
1. Configure a project with "Require Change-Id in commit message"
2. Try to push a change for this project without a Change-Id in the commit message.

What is the expected output? What do you see instead?

git prints out some output like:

remote: ERROR: missing Change-Id in commit message
remote: Suggestion for commit message:
remote: test gerrit change
remote: 
remote: Change-Id: I7f56755cdd8eb10f672f517d8ecd6784e2966bc1

This is helpful, but it would be nice to also mention that a commit-msg hook is available to automatically add these change-ids.  E.g., trying to push to gerrit.googlesource.com should advise installing the commit hook at https://gerrit-review.googlesource.com/tools/hooks/commit-msg.
Oct 15, 2012
#1 mdemp...@google.com
(Sorry, I meant to file this as a Feature Request, not a Bug.)
Oct 19, 2012
Project Member #2 choro...@wikimedia.org
(No comment was entered for this change.)
Labels: -Type-Bug Type-Feature
Oct 21, 2012
#3 sop@google.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.6
Jun 25, 2013
Project Member #4 david.pu...@sonymobile.com
 Issue 1972  has been merged into this issue.
Sign in to add a comment

Powered by Google Project Hosting