My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1603: No score comment removes the previous "-1" score, both comments are from the same person.
  Back to list
Status:  WontFix
Owner:  ----
Closed:  Oct 2012


Sign in to add a comment
 
Reported by sezginmu...@gmail.com, Oct 10, 2012
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version: 2.4.2

What steps will reproduce the problem?
1. Add a -1 comment to a review.
2. Add "No Score" comment
3. See that the -1 was removed.

What is the expected output? What do you see instead?

I would expect to see the -1 after the "No Score" comment.


Please provide any additional information below.

Oct 10, 2012
Project Member #1 edwin.ke...@gmail.com
This is intended. 
Whenever a user votes on a change, he overwrites his previous vote.
When clicking the review button, the existing vote is pre-selected, so there is no danger in accidentally loosing it. Only if the user explicitly changes the selection, the voting will be changed. If the voting is changed from -1 to 0, then the -1 vote is of course removed and replaced by the 0 vote. How else a user could remove his -1 if he changes his mind about the change?
Status: WontFix
Sign in to add a comment

Powered by Google Project Hosting