My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1594: Document the need to chmod +x the commit-msg script after downloading
1 person starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Oct 2012


Sign in to add a comment
 
Reported by aleksand...@gmail.com, Oct 3, 2012
The commit-msg hook script must have the execution bit set in order to be invoked by Git.

The published instructions at http://gerrit-documentation.googlecode.com/svn/Documentation/2.4.2/cmd-hook-commit-msg.html don't document it yeet, but a note about it has already been committed to Git repo by David Pursehouse on 16 August (commit 056ed18).

However, downloading the script is also documented in http://gerrit-documentation.googlecode.com/svn/Documentation/2.4.2/user-changeid.html and the same note is needed there.

Attaching a patch.
0001-Add-a-note-about-setting-the-execute-permission-bit-.patch
959 bytes   View   Download
Oct 3, 2012
Project Member #1 choro...@wikimedia.org
Submitted, thanks for the patch.

https://gerrit-review.googlesource.com/#/c/38180/
Status: Submitted
Oct 3, 2012
Project Member #2 david.pu...@sonymobile.com
Thanks.  This should have been added in user-changeid with 056ed18.  My bad :(

Oct 23, 2012
Project Member #3 david.pu...@sonymobile.com
(No comment was entered for this change.)
Labels: FixedIn-2.5
Oct 31, 2012
Project Member #4 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting