| Issue 158: | Please have a clearer distinction between "reviewers" and people CCed on changes | |
| Back to list |
Reported by David Brown <dab@android.com> on Thu Apr 30 13:40:14 PDT 2009
Source: JIRA GERRIT-158
If I use the --cc feature of repo upload like this:
repo upload --reviewers=<email_addresses> --cc=<email_addresses>
the resulting gerrit web page shows the reviewers *and* the CCed people
lumped together in the "Approvals" section. That's confusing, since CCing
someone on a code review just means "FYI"; it's not an actual request for
a code review or approval.
It would be more clear for the reviewers and CC list to be treated
separately:
- In the web UI, only the actual reviewers should be listed in the
"Approvals" section. The CC list should be shown separately.
- There could then be a button to people to the CC list (just like you
can add new reviewers now)
- In the email requesting a review, please make it more clear who the
reviewers are (rather than just having reviewers in the To field and
the others in the CC field.)
Just having a sentence of text at the very start of the message, like
Mondrian does, should be enough. For example:
Hello <reviewers>,
I'd like you to do a code review.
New change 535 for donut:
<etc.>
(Hmmm, I guess that last part is basically the same request as
http://jira.source.android.com/jira/browse/GERRIT-149 .)
Sep 24, 2009
#1
code-rev...@gtempaccount.com
Sep 24, 2009
Comment by Shawn Pearce <sop@google.com> on Thu May 21 11:39:11 PDT 2009 Fixed by https://review.source.android.com/10033
Sep 24, 2009
Update by Shawn Pearce <sop@google.com> on Thu May 21 11:39:11 PDT 2009 Fixed in version 2.0.13.
Status:
Fixed
Sep 25, 2009
(No comment was entered for this change.)
Labels:
FixedIn-2.0.13
Oct 25, 2012
(No comment was entered for this change.)
Status:
Released
|
|
| ► Sign in to add a comment |