My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1569: The commit-msg hook may fail if GREP_OPTIONS are set
1 person starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Oct 2012


Sign in to add a comment
 
Reported by icee...@googlemail.com, Sep 19, 2012
Affected Version:
2.4.2+

What steps will reproduce the problem?
1. set GREP_OPTIONS to include --exclude=".git/*" 
2. try to amend a commit

What is the expected output? What do you see instead?
Each amend adds another Change-Id: line


Please provide any additional information below.
Possible solution: 
Unset GREP_OPTIONS before calling grep in the hook.
Oct 18, 2012
Project Member #1 david.pu...@sonymobile.com
This is fixed [1]

[1] https://gerrit-review.googlesource.com/#/c/38001/

Oct 18, 2012
Project Member #2 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.6
Feb 5, 2013
Project Member #3 david.pu...@sonymobile.com
(No comment was entered for this change.)
Labels: -FixedIn-2.6 FixedIn-2.5.2
Feb 12, 2013
Project Member #4 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting