My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1559: Add the list of files in stream-events entries
2 people starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Reported by florent....@intersec.com, Sep 13, 2012
We use buildbot's gerrit changesource module that itself use gerrit stream-events command to get notified of new commits/reviews. In order to improves the workflow of our buildbot we need to be informed of the list of files affected by each patchset.

Currently, stream-events does not provide that information and we must perform an additional gerrit query --files (which mean initiating a new ssh connection per patchset).

It would be great if gerrit stream-events could learn a --files switch identical to gerrit query's one. With this switch on, gerrit would add a new "files" array in the JSON output for the ref-updated and patchset-created events.
Jul 6, 2015
#1 ad...@tsumobi.com
The absence of this field seems to contradict the stream-events documentation. I realize that the documentation also says something to the effect of "any of these fields may be missing." Is this actually a simple bug or is there some other more nuanced reason for why this field is absent from the emitted events?
Jul 6, 2015
Project Member #2 edwin.ke...@gmail.com
Maybe the documentation is incorrect then. Do you mind to push a fix for the documentation?
Looking at the code, I can see that for the stream-events the files are never provided and the change that added the 'files' field only implemented support for getting the files with the ssh query command [1]. This means getting the list of files with the stream-events is still not supported.

[1] https://gerrit-review.googlesource.com/30290
Sign in to add a comment

Powered by Google Project Hosting