My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1555: If not all patchsets are visible, the diff view is not working.
1 person starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Sep 2012


Sign in to add a comment
 
Reported by icee...@googlemail.com, Sep 12, 2012
Affected Version:
2.4.2-674-gb8bea1b

What steps will reproduce the problem?
1. Have a change where only some changes are visible (e.g. https://gerrit-review.googlesource.com/#/c/37661/)
2. Try to use the diff view
3. nothing happens

What is the expected output? What do you see instead?

Normally you would want to see the diff output.
Please provide any additional information below.

Sep 12, 2012
Project Member #1 edwin.ke...@gmail.com
I'm the owner of that change and for me it's the same problem :-(
I think what is causing the problem is that I deleted all the old draft patch sets...
Status: Accepted
Sep 12, 2012
#2 icee...@googlemail.com
Yes, that seems correct. 

So to reproduce:
 1. create a change with some draft pachtsets ( push to refs/drafts/<branch>)
 2. publish the most recent draft
 3. delete at least one of the earlier drafts
 4. diff view is not possible anymore ( and nothing is in the error_log)
Sep 12, 2012
#3 icee...@googlemail.com

git fsck in the gerrit git repository shows the deleted commit as dangling
git fsck  --dangling --unreachable --full --strict
Checking object directories: 100% (256/256), done.
Checking objects: 100% (143/143), done.
unreachable commit 979802960a925113b6fc6f8933548cdb0cf87868 <-- this the deleted draft
unreachable blob b9c5bc12a6204c65921aa3753fbeaa240be8d6dd  <--- content of deleted draft

Sep 13, 2012
Project Member #4 edwin.ke...@gmail.com
Pushed a fixed for review:
https://gerrit-review.googlesource.com/37810
Sep 16, 2012
#5 sop@google.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.5
Oct 31, 2012
Project Member #6 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting