| Issue 1545: | commentlink interferes with implicitly linkified URLs | |
| 1 person starred this issue and may be notified of changes. | Back to list |
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC. *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS! *****
************************************************************
Affected Version:2.4.2
What steps will reproduce the problem?
1. Setup a commentlink with a match expression of \\b([0-9a-f]{7,40})(?=[^0-9a-f]) -- this attempts to match SHA1s or partial SHA1s and turn them into links.
2. Add a comment containing a gitweb URL such as http://git.chromium.org/gitweb/?p=external/libjingle.git;a=commitdiff;h=7e47565
3. View the comment; it's mangled since gerrit automatically linkifies URLs (something starting with https?:// I guess), and the comment link interferes with that.
What is the expected output? What do you see instead?
A mangled comment on the link containing the URL. Ideally commentlink matches should skip over anything gerrit has already automatically linkified.
Sep 4, 2012
Project Member
#1
choro...@wikimedia.org
Sep 4, 2012
Thanks; I thought I searched for commentlink before I filed, but I guess I didn't.
Status:
Duplicate
Mergedinto: 1451 |
|
| ► Sign in to add a comment |