My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1545: commentlink interferes with implicitly linkified URLs
1 person starred this issue and may be notified of changes. Back to list
Status:  Duplicate
Merged:  issue 1451
Owner:  ----
Closed:  Sep 2012


Sign in to add a comment
 
Project Member Reported by jaysoff...@gmail.com, Aug 31, 2012
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version:2.4.2

What steps will reproduce the problem?
1. Setup a commentlink with a match expression of \\b([0-9a-f]{7,40})(?=[^0-9a-f]) -- this attempts to match SHA1s or partial SHA1s and turn them into links.
2. Add a comment containing a gitweb URL such as http://git.chromium.org/gitweb/?p=external/libjingle.git;a=commitdiff;h=7e47565
3. View the comment; it's mangled since gerrit automatically linkifies URLs (something starting with https?:// I guess), and the comment link interferes with that.

What is the expected output? What do you see instead?

A mangled comment on the link containing the URL. Ideally commentlink matches should skip over anything gerrit has already automatically linkified.


Sep 4, 2012
Project Member #1 choro...@wikimedia.org
Pretty sure this is a duplicate issue--I know we've discussed it before. Just can't find it offhand.
Sep 4, 2012
Project Member #2 jaysoff...@gmail.com
Thanks; I thought I searched for commentlink before I filed, but I guess I didn't.
Status: Duplicate
Mergedinto: 1451
Sign in to add a comment

Powered by Google Project Hosting