My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1503: Skip Uncommented loses state after adding comment
1 person starred this issue and may be notified of changes. Back to list
Status:  Invalid
Owner:  ----
Closed:  Aug 2012


Sign in to add a comment
 
Reported by cryan.du...@gmail.com, Aug 1, 2012
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version:

What steps will reproduce the problem?
1. View a patchset which has comments added by a reviewer starting with the first file in the patchset.
2. select Preferences and check Skip Uncommented, hit Update
3. Navigate to the next commented file. Add a response to the comment
   such as "Done"
4. Navigate to the next file, the Skip Uncommented state has been cleared/dropped, reverting back to navigating through all files 

What is the expected output? What do you see instead?

The skip uncommented should remain selected until I uncheck it, or perhaps select Up to Change (ie drop out of navigating differences)

Please provide any additional information below.

Aug 8, 2012
Project Member #1 edwin.ke...@gmail.com
This is the intended behaviour. The 'Update' button only updates the display, but it doesn't persist the preferences. Whenever the PatchScreen is reloaded the changes done by Update are reset. If you want to persist the preferences use the Save button instead. For more details see [1].

[1] https://gerrit-review.googlesource.com/24356
Status: Invalid
Sign in to add a comment

Powered by Google Project Hosting