My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1494: Text alignment breaks w/syntax coloring enabled when using Lucida Console
4 people starred this issue and may be notified of changes. Back to list
Status:  Submitted
Owner:  ----
Closed:  Sep 2012


Sign in to add a comment
 
Reported by tomfine...@google.com, Jul 26, 2012
Affected Version: 2.18 (gerrit.chromium.org) HEAD on master has the same CSS.

What steps will reproduce the problem?
1. Use Windows or Mac
2. Enable syntax coloring in side by side diff
3. Alignment is incorrect

What is the expected output? 
Aligned text using a monospace font that is monospaced across all font weights.

What do you see instead?
Text that is not aligned because Lucida Console and Monaco are being used as mono space fonts.

Please provide any additional information below.
Removing Lucida Console and Monaco from gerrit.css will fix the problem. 

Patch attached/I'll get a contributor agreement signed and submit the patch per SUBMITTING_PATCHES if that's truly preferred. In this case it seems that's overkill when all I want is a quick fix to this (seemingly) simple problem.
fix_css.patch
717 bytes   View   Download
Aug 27, 2012
#1 fgalli...@chromium.org
This is also broken on Linux. Version 22.0.1229.14 beta
Aug 27, 2012
Project Member #2 bklarson@gmail.com
Sorry, we do need you to follow the SUBMITTING_PATCHES guide if possible.  If that isn't possible for some reason, please let us know why.
Aug 27, 2012
#3 tomfine...@google.com
Patchset is here: https://gerrit-review.googlesource.com/#/c/37690/

2 questions:

1) Who should I add as a reviewer?

2) What do I need to do as far as the CLA goes? I'm a Google employee, and this is related to WebM project work (specifically, phantom style nits caused by this bug have impacted code reviews on gerrit.chromium.org). Basically, the CLA goes back to the company that I'm employed by, and I'm already authorized to submit code to open source projects. Is this just a completeness thing, and I'll need to get sign off regardless of the preceding information?


Aug 27, 2012
#4 tomfine...@google.com
Re question 1: tag, you're it. :)

(found you in the log for the file, figured that would be ok!)
Aug 27, 2012
Project Member #5 edwin.ke...@gmail.com
I think as Googler you should be fine with the CLA.
Anyone who doesn't have a valid CLA is actually not able to upload new changes or patch sets for the Gerrit projects.
Sep 16, 2012
#6 sop@google.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.6
Oct 17, 2012
Project Member #7 bklarson@gmail.com
 Issue 1612  has been merged into this issue.
Jul 23, 2013
Project Member #8 bklarson@gmail.com
 Issue 2030  has been merged into this issue.
Sign in to add a comment

Powered by Google Project Hosting