Affected Version: 2.4.2
What steps will reproduce the problem?
1. Review and approve a change, using the "Publish and Submit" button
2. Look at the order of the comments on the change
What is the expected output?
The expected order would be:
1:37 PM Roan Kattouw - Looks good to me, approved
1:37 PM Gerrit - Change was merged successfully
What do you see instead?
The order is reversed:
1:37 PM Gerrit - Change was merged successfully
1:37 PM Roan Kattouw - Looks good to me, approved
This is really annoying because only the last comment is shown by default, so if a merge failed due to a path conflict, this is not immediately obvious. It's also just wrong, because the change was merged after it was approved, not before. Previous version of Gerrit didn't have this issue.
Example change with this issue: https://gerrit.wikimedia.org/r/#/c/9053/
Change merged in a previous version that didn't have this issue: https://gerrit.wikimedia.org/r/#/c/12345