My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1444: Gerrit should not use the Mailing-List SMTP header
2 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Jan 2013


Sign in to add a comment
 
Reported by cyounk...@gmail.com, Jun 16, 2012
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version:

What steps will reproduce the problem?
1. Configure Amazon SES on an MTA 
2. Configure Gerrit to use the MTA
3. Create a change or comment, which should trigger a notification

What is the expected output? What do you see instead?

I expect the email to be sent. Instead, Amazon SES replies indicating that they do not support the Mailing-List header.

Here is a list of headers they support: http://docs.amazonwebservices.com/ses/latest/DeveloperGuide/Headers.html

I do not believe Gerrit should use this header. Page 4 of RFC 4021 lists valid headers, and Mailing-List is not there. I believe using the List-ID header should be sufficient.

Please provide any additional information below.

Line of code: https://code.google.com/p/gerrit/source/browse/gerrit-server/src/main/java/com/google/gerrit/server/mail/ChangeEmail.java#168

RFC 4021 - http://tools.ietf.org/html/rfc4021
Jan 17, 2013
#1 sop@google.com
https://gerrit-review.googlesource.com/41370
Status: Submitted
Labels: FixedIn-2.6
Feb 12, 2013
Project Member #2 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Released
Mar 6, 2013
Project Member #3 edwin.ke...@gmail.com
This was cherry-picked for 2.5.2 [1].

[1] https://gerrit-review.googlesource.com/41520
Labels: -FixedIn-2.6 FixedIn-2.5.2
Sign in to add a comment

Powered by Google Project Hosting