My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 144: Add optional "auto-verify" of uploaded changes
  Back to list
Status:  Accepted
Owner:  ----
Cc:  dab%andr...@gtempaccount.com

Blocked on:
issue 56


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by David Brown <dab@android.com> on Fri Apr 24 15:02:11 PDT 2009
Source: JIRA GERRIT-144

Internally to google, submitters are allowed to 'verify' their own uploads
(since it's presumed that we've built and tested our own changes.)

But currently, verifying your own change is a little cumbersome, since (a)
you have to separately bring up the change in a web browser, publish
comments, and click the 'verified' checkbox, and (b) this results in one
extra useless email getting sent to all the reviewers/CCs.

To make this simpler, could there be a way to automatically mark uploaded
changes as verified?

One possibility: have a per-user setting saying that "any change I repo
upload should be automatically marked as 'verified'"

Or, maybe add a command-line option to "repo upload" saying "mark this
change 'verified' initially".

This feature probably should be available only for certain repositories.
It wouldn't be allowed in the external Android repo, for example.


(Sorry if this is a dup; I searched jira and only found
<http://jira.source.android.com/jira/browse/GERRIT-56>, which was about
the old behavior where uploads were verified AND approved by default.
*This* RFE is only about the 'verify' step, and only for googlers working
in the internal repo.)
Sep 24, 2009
#1 sop+code@google.com
(No comment was entered for this change.)
Status: Accepted
Owner: ---
Blockedon: 56
Sep 24, 2009
#2 sop+code@google.com
(No comment was entered for this change.)
Cc: d...@android.com
Sign in to add a comment

Powered by Google Project Hosting