My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1409: $email.changeUrl is empty
1 person starred this issue and may be notified of changes. Back to list
Status:  WontFix
Owner:  ----
Closed:  May 2012


Sign in to add a comment
 
Reported by luc-bac...@box.com, May 24, 2012
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version:
lastets stable 2.3

What steps will reproduce the problem?
1. create review and add reviewer
2.make change


in the template ReplacePatchSet.vm

add the add the line:

#end
#else
$fromName has uploaded a new patch set (#$patchSet.patchSetId).

    Please visit this awesome link : $email.changeUrl

#end


What is the expected output? What do you see instead?

the email should get the line with the instead is show

Please visit this awesome link : $email.changeUrl


-> the $mail.changeUrl is not replaced with the url


Please provide any additional information below.

I believe the majority of the majority of the gerrit users would always
want to get the url!


May 24, 2012
#1 luc-bac...@box.com
the email should get the line with the instead is show

i meant


the email should get the line with the url to the change but instead is shows



May 24, 2012
#2 sop@google.com
Did you set gerrit.canonicalWebUrl in gerrit.config?

This usually needs to be set to get a valid URL in emails.
Status: WontFix
May 24, 2012
#3 luc-bac...@box.com
ARG! Thanks that did it, we copied the old config that didn't had this setup
thanks!
Sign in to add a comment

Powered by Google Project Hosting