My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1408: No push possible via HTTP
25 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Dec 2012


Sign in to add a comment
 
Reported by lars.klo...@software-friends.de, May 24, 2012
Affected Versions: 2.2, 2.3-rc0 and 2.3

What steps will reproduce the problem?
1. git push http://<gerritURL>/p/<project>

What is the expected output? What do you see instead?
- Expected: push successful
- Instead: following error:
fatal: The remote end hung up unexpectedly
fatal: The remote end hung up unexpectedly
error: RPC failed; result=22, HTTP code = 500

Please provide any additional information below:

On the server the following is logged:
[2012-04-13 11:36:15,905] WARN  org.eclipse.jetty.util.log : /gerrit/p/testProject/git-receive-pack
java.lang.IllegalStateException: Request has already been cleaned up
        at
com.google.gerrit.server.RequestCleanup.add(RequestCleanup.java:42)
        at
com.google.gerrit.server.config.RequestScopedReviewDbProvider.get(RequestScopedReviewDbProvider.java:48)
        at
com.google.gerrit.server.config.RequestScopedReviewDbProvider.get(RequestScopedReviewDbProvider.java:27)
... (rest of the stack trace)

It seems, the POST probe and the actual POST use the same RequestCleanup instance.

See discussion thread: http://groups.google.com/group/repo-discuss/browse_thread/thread/38fea18352986a1f#
Jun 5, 2012
#1 mariu...@gmail.com
Gerrit 2.4


[2012-06-05 10:23:48,453] INFO  org.eclipse.jetty.util.log : jetty-7.2.1.v20101111
[2012-06-05 10:23:49,030] INFO  org.eclipse.jetty.util.log : Started SelectChannelConnector@0.0.0.0:10000
[2012-06-05 10:23:49,032] INFO  com.google.gerrit.pgm.Daemon : Gerrit Code Review 2.4 ready

[2012-06-05 10:49:09,438] WARN  org.eclipse.jetty.util.log : /p/my_project.git/git-receive-pack
java.lang.IllegalStateException: Request has already been cleaned up
        at com.google.gerrit.server.RequestCleanup.add(RequestCleanup.java:42)
        at com.google.gerrit.server.config.RequestScopedReviewDbProvider.get(RequestScopedReviewDbProvider.java:48)
        at com.google.gerrit.server.config.RequestScopedReviewDbProvider.get(RequestScopedReviewDbProvider.java:27)
        at com.google.inject.internal.BoundProviderFactory.get(BoundProviderFactory.java:55)
        at com.google.inject.internal.ProviderToInternalFactoryAdapter$1.call(ProviderToInternalFactoryAdapter.java:46)
        at com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1031)
        at com.google.inject.internal.ProviderToInternalFactoryAdapter.get(ProviderToInternalFactoryAdapter.java:40)
        at com.google.inject.servlet.ServletScopes$1$1.get(ServletScopes.java:88)
        at com.google.inject.internal.InternalFactoryToProviderAdapter.get(InternalFactoryToProviderAdapter.java:40)
        at com.google.inject.internal.SingleParameterInjector.inject(SingleParameterInjector.java:38)
        at com.google.inject.internal.SingleParameterInjector.getAll(SingleParameterInjector.java:62)
        at com.google.inject.internal.ConstructorInjector.construct(ConstructorInjector.java:84)
        at com.google.inject.internal.ConstructorBindingImpl$Factory.get(ConstructorBindingImpl.java:254)
        at com.google.inject.internal.InjectorImpl$4$1.call(InjectorImpl.java:978)
        at com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1031)
        at com.google.inject.internal.InjectorImpl$4.get(InjectorImpl.java:974)
        at com.google.inject.assistedinject.FactoryProvider2.invoke(FactoryProvider2.java:632)
        at com.google.gerrit.server.git.$Proxy53.create(Unknown Source)
        at com.google.gerrit.server.git.AsyncReceiveCommits.<init>(AsyncReceiveCommits.java:151)
        at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
        at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
        at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
        at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
        at com.google.inject.internal.DefaultConstructionProxyFactory$2.newInstance(DefaultConstructionProxyFactory.java:85)
        at com.google.inject.internal.ConstructorInjector.construct(ConstructorInjector.java:85)
        at com.google.inject.internal.ConstructorBindingImpl$Factory.get(ConstructorBindingImpl.java:254)
        at com.google.inject.internal.InjectorImpl$4$1.call(InjectorImpl.java:978)
        at com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1024)
        at com.google.inject.internal.InjectorImpl$4.get(InjectorImpl.java:974)
        at com.google.inject.assistedinject.FactoryProvider2.invoke(FactoryProvider2.java:632)
        at $Proxy52.create(Unknown Source)

...
Aug 17, 2012
#2 oli.Bra...@googlemail.com
Gerrit 2.4.2 fails in this special case, too. Tried with http://openocd.zylin.com.

By the way: Why the "minor" priority? If you're behind a firewall (a lot of people have this problem due to company policies) this is a real show-stopper.

Regards
Oliver
Aug 17, 2012
#3 volc...@gmail.com
What makes you believe this this has anything to do with firewall. As far as my research went it seems to be related to Gerrit/Guice/Jetty interaction.

The discussion thread is @ https://groups.google.com/d/topic/repo-discuss/OP6hg1KYah8/discussion

Regards,

Vladimir
Aug 18, 2012
#4 oli.Bra...@googlemail.com
Hi Vladimir,

the bug has nothing to with a firewall. But if you are behind a firewall a "push over http" is mostly the only chance to contribute to a project (if this project makes use of Geritt ;) ).

Regards
Oliver
Sep 18, 2012
#5 lars.kne...@googlemail.com
Is there anything we can do to help with this issue?

We are stuck at version 2.2.x because of this problem.
Nov 28, 2012
#6 tobias.o...@sap.com
FYI - There is some discussion happening on an issue with a similar stack trace: https://bugs.eclipse.org/bugs/show_bug.cgi?id=393735
Dec 12, 2012
Project Member #7 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Released
Labels: FixedIn-2.5.1
Sign in to add a comment

Powered by Google Project Hosting