My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 140: Unambiguously differentiate submit from other activity
1 person starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  code-rev...@gtempaccount.com
Closed:  Oct 2012


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by <danfuzz@android.com> on Mon Apr 20 15:51:09 PDT 2009
Source: JIRA GERRIT-140
Environment: n/a

For mail filtering purposes, I think it would be handy if the email generated
by a submit was unambiguously differentiated from other activity on a change.
Right now, there seem to be at least a couple different templates used in the
emails sent out. Here are examples I could find:

    Dan Bornstein has submitted change 278 to master:
    Change 329 by Andy McFadden submitted to master.

Maybe the first one is an old version and all new ones look like the second?
If not, it'd be nice to standardize.

But also, there's not a lot a filter can hang on in that line. In particular,
it looks like the best I can do is look for "change" and "submitted" on the
same line, which seems less than ideal. Also, FWIW, Gmail doesn't have a way
to express that as a filter; the best I can do with it is look for an email
that as both "change" and "submitted" anywhere in the body, and since many
Gerrit emails have arbitrary changelog text, things can go off the rails
pretty quickly.

I know it breaks Gmail threading, but maybe it'd be appropriate to use a
different subject line for submits vs other change activity? Maybe it should
be a user configurable option? Sorry, I don't have a concrete suggestion, but
I thought I'd bring the problem to your attention.
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Mon Apr 20 15:59:10 PDT 2009

The first example above ("Dan Bornstein has submitted ...") is the old
version, and the second example above ("Change 329 by Andy McFadden
submitted ...") is the new version.  This was changed in response to
GERRIT-138.

Sadly, GMail doesn't have sufficient filters by email headers.  There is a "X-
Gerrit-MessageType: merged" header on these messages, but GMail doesn't offer
a way to filter based upon an arbitrary header.

Maybe we should put the message type into the body, below the "--", so we can
at least filter on that using a body text filter.

I'm not too interested in breaking the message threading for a change.  I
think its useful to have the submit message in the same thread as the review.
Quite unlike p4 at Google.  So changing the subject would break that.
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Comment by <danfuzz@android.com> on Mon Apr 20 16:17:22 PDT 2009

Thanks for the analysis. I missed that there was a header, but yeah, it's
unfortunately useless with Gmail. Not your fault, of course.
Sep 24, 2009
#3 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Wed May 20 19:25:39 PDT 2009
Sep 24, 2009
#4 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Thu May 21 11:39:10 PDT 2009

Fixed by https://review.source.android.com/10033
Sep 24, 2009
#5 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Thu May 21 11:39:10 PDT 2009

Fixed in version 2.0.13.
Status: Fixed
Sep 25, 2009
#6 code-rev...@gtempaccount.com
(No comment was entered for this change.)
Labels: FixedIn-2.0.13
Oct 25, 2012
#7 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting