My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1380: comments should display time along with date
  Back to list
Status:  Released
Owner:  sop@google.com
Closed:  Jan 2013


Sign in to add a comment
 
Reported by pravinse...@gmail.com, May 8, 2012
Affected Version: 2.2.2

Comments for a change display only the date of the comment if it is older than a day. For comments which were added a few days back, it becomes impossible to find the time difference between actions.

This is especially useful for information on time taken by an engineer to mark the change as verified or time taken by +2CR reviewer after +1CR was given.

The time-stamp is already stored in the DB. Displaying it on screen helps.

May 9, 2012
#1 prav...@nvidia.com
The time does get highlighted if the cursor is taken on the date, but this is not intuitive and helpful.

It can be changed to display May 05, 2:00 PM instead of just May 05.
May 9, 2012
#2 sop@google.com
(No comment was entered for this change.)
Status: Accepted
Owner: sop@google.com
May 11, 2012
#3 pravinse...@gmail.com
I made this change and verified it. It's a small change in FormatUtil.shortFormat()
from
return sDate.format(dt);
to
final StringBuilder b = new StringBuilder();
b.append(sDate.format(dt));
b.append(", ");
b.append(sTime.format(dt));
return b.toString();

where sDate and sTime are set to user preferences.

I will upload it for review.

Thanks
Jan 5, 2013
Project Member #4 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Released
Labels: FixedIn-2.5
Sign in to add a comment

Powered by Google Project Hosting