My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 138: Gerrit's email notifications should show the author of a change (not just the submitter)
  Back to list
Status:  Released
Owner:  code-rev...@gtempaccount.com
Closed:  Oct 2012


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by David Brown <dab@android.com> on Wed Apr 15 16:26:53 PDT 2009
Source: JIRA GERRIT-138

Here's an email I got from gerrit earlier today:

   Date: Wed, 15 Apr 2009 12:13:08 -0700 (PDT)
   From: John Huang <jsh@google.com>
   To: Tammo Spalink <tammo@google.com>
   Cc: John Huang <jsh@google.com>
   Cc: Wink Saville <wink@google.com>
   Subject: Change 186: (platform/frameworks/base) eliminate seemingly
    pointless conversion to and then from he...

   John Huang has submitted change 186 to donut:

     https://android-git.corp.google.com/g/186

   eliminate seemingly pointless conversion to and then from hex string

   ---
   M telephony/java/com/android/internal/telephony/gsm/SIMRecords.java

   --
   To view visit https://android-git.corp.google.com/g/186
   To unsubscribe, visit https://android-git.corp.google.com/g/settings


But the *author* of this change was Tammo Spalink, not John Huang.
John just submitted it.

I bet it's more useful to know the author than the (fairly arbitrary)
person who pushed the "submit" button, so could this email message mention
the author on the first line?

It's fine to mention the submitter too, I guess...
How about replacing that first line with a 2-line summary like this:

  Change ### by <author-name> to <branch-name>:
  (Submitted by <submitter-name> on Wed, 15 Apr 2009 12:13:08 PDT)
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Wed Apr 15 16:54:50 PDT 2009

How about if the email stays as being sent from the submitter, but the first
line changes to:

  Change #### from AUTHOR submitted to BRANCH.

?
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Comment by David Brown <dab@android.com> on Wed Apr 15 17:26:54 PDT 2009

Sure, sounds great to me.  The author is the important part.  (And if I really
care about
the submitter, I don't mind having to look at the From: line to figure it out.)
Sep 24, 2009
#3 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Wed Apr 15 17:44:31 PDT 2009

Fixed by https://review.source.android.com/9545
Sep 24, 2009
#4 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Wed Apr 15 17:44:31 PDT 2009

Fixed in version 2.0.10.
Status: Fixed
Sep 25, 2009
#5 code-rev...@gtempaccount.com
(No comment was entered for this change.)
Labels: FixedIn-2.0.10
Oct 25, 2012
#6 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting