My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1376: Added as reviewer for a draft doesn't generate stream-events
2 people starred this issue and may be notified of changes. Back to list
Status:  Submitted
Owner:  ----
Closed:  Oct 2012


Sign in to add a comment
 
Reported by gonz...@gmail.com, May 7, 2012
Affected Version: 2.3

What steps will reproduce the problem?
1. Push a commit as user A, git push origin HEAD:refs/drafts/master
2. Listen for stream-events as user B, ssh -p 29418 B@gerrit.example.net gerrit stream-events
3. Add user B as a reviewer for commit pushed in step 1. 

What is the expected output? What do you see instead?
I expect to be notified about a new draft similar to what I see when a new change/patch set is uploaded.

Please provide any additional information below.
This is useful for the Jenkins plugin gerrit-trigger.
Jun 27, 2012
Project Member #1 david.pu...@sonymobile.com
Is any event even generated for being added as a reviewer for normal changes, i.e. those that are not draft?  As far as I know, not, unless it's covered by `comment-added`.

Similar to this is  issue 1437  [1] which has recently been fixed [2].  With this fix a new event `draft-published` is generated when a change is moved from draft to new.  This new event is not handled in the current version of the trigger plugin, but should be included in the next release.

[1] https://code.google.com/p/gerrit/issues/detail?id=1437
[2] https://gerrit-review.googlesource.com/#/c/36050/
Jul 25, 2012
#2 gonz...@gmail.com
You are correct that there is no event generated when you are added as a reviewer for normal changes either.

The idea would be to trigger a build in Jenkins by adding the user which gerrit-trigger is using. Perhaps it is enough to have draft-published.
Oct 2, 2012
Project Member #3 david.pu...@sonymobile.com
I've uploaded a change to send a "reviewer-added" event.

https://gerrit-review.googlesource.com/38133

Oct 23, 2012
Project Member #4 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.6
Sign in to add a comment

Powered by Google Project Hosting