My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1370: Loading diff view slows down when paging through files
7 people starred this issue and may be notified of changes. Back to list
Status:  Submitted
Owner:  sop@google.com
Closed:  Apr 2013
Cc:  cran...@google.com


Sign in to add a comment
 
Reported by simoncog...@gmail.com, May 3, 2012

> Affected Version:

2.3

> What steps will reproduce the problem?

1. Submit a patchset that contains lots of changes
2. View the first file in the patchset
3. Use ']' key to move through the files in the patchset (or press the next file link)
4. The more files you go through the slower it gets to load the next file. Clicking 'Up to change' then going back to where you left off temporarily fixes the issue.

> What is the expected output? What do you see instead?

Expect the speed of moving through files to remain constant.

> Please provide any additional information below.

I've uploaded a Chrome dev tools timeline file which shows the keypress event time increasing up to 3+ seconds per page after viewing just a few files:

http://dl.dropbox.com/u/64359/GerritTimelineRawData-20120504T103230.json

(it was too big to attach)

Looking inside the event there are a huge number of "parse" calls happening to this function:

function syc(b, c, d) {
    b.e = false;
    d ? (b.c.innerHTML = c || WZc, undefined) : (b.c.textContent = c || WZc, undefined);
    if (b.f != b.d) {
        b.f = b.d;
        YYb(b.c, b.d)
    }
}

Occurring for me in Chrome 17.0.963.66 and Firefox on Ubuntu.
May 3, 2012
#1 sop@google.com
There is a known memory leak here in Gerrit, reloading the tab/window causes the leak to be cleaned up and things start behaving well again.


Status: Accepted
Owner: sop@google.com
Cc: cran...@google.com
Labels: -Priority-Minor Priority-Critical
Mar 6, 2013
Project Member #3 david.pu...@sonymobile.com
 Issue 1809  has been merged into this issue.
Apr 26, 2013
#4 sop@google.com
https://gerrit-review.googlesource.com/45035
Status: ChangeUnderReview
Apr 26, 2013
#5 sop@google.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.6
Sign in to add a comment

Powered by Google Project Hosting