My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 136: Key shortcuts for the review workflow
  Back to list
Status:  Released
Owner:  code-rev...@gtempaccount.com
Closed:  Oct 2012


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Christopher Tate <ctate@google.com> on Wed Apr 15 11:51:22 PDT 2009
Source: JIRA GERRIT-136

It would be extremely handy if Gerrit were to have Mondrian-like key shortcuts
for navigating during the review workflow:  n/p to move to the next/previous
diff location during review of a file, j/k to move to the next/previous file
in the patch set, etc.
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by David Brown <dab@android.com> on Fri May 08 13:31:13 PDT 2009

Other than n/p and j/k, by the way, the other important shortcut is "u" to
go back up from a file diff to the Change page.

(I'm especially missing these keys now that I have "whole file" context
turned on for diffs, FWIW.  Without n/p, it's easy to miss a diff entirely
when scrolling thru a large file...)
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Fri May 15 18:40:29 PDT 2009

'u' is implemented by https://review.source.android.com/9923

j/k works on more browsers, but is still missing from the file list within a
change.

n/p is still unsupported.

I will try to finish this soon,  maybe early next week.
Sep 24, 2009
#3 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Sat May 16 14:33:05 PDT 2009

n/p within a patch is implemented by https://review.source.android.com/9951

j/k within a file list is still not working.
Sep 24, 2009
#4 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Sat May 16 19:38:31 PDT 2009

https://review.source.android.com/9967 adds 'f' within a patch view to open a
list of files and permit you to browse through them with j/k.  This is faster
than using 'u' to return to the change page, because 'f' is using a cached
list of the files and comment counts.

I'm calling this "fixed" at this point because I can now do the entire review-
comment-start publish cycle with the keyboard.

There's plenty of other features that would help, like say Mondrian's 'm', but
that will be trivial to add once we actually have per-file marks.
Sep 24, 2009
#5 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Sat May 16 19:38:31 PDT 2009

Fixed in version 2.0.12.
Status: Fixed
Sep 25, 2009
#6 code-rev...@gtempaccount.com
(No comment was entered for this change.)
Labels: FixedIn-2.0.12
Oct 25, 2012
#7 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting