| Issue 1328: | Bad links to diff files named with plus sign ("+") | |
| 6 people starred this issue and may be notified of changes. | Back to list |
Affected Version:
Occurs in version 2.2.2.1
What steps will reproduce the problem?
1. Submit a patch that contains a file with a plus sign ("+") in the filename.
2. In Gerrit, open the change/patch set containing the patch.
3. Click on the link to review the specific file. (Hint: Click in directly, don't start with the commit message and click the "next file" links.)
What is the expected output? What do you see instead?
* You expect to see the file's side-by-side diff.
* Instead, you see nothing to diff -- the same as if you had entered a non-existant filename.
Please provide any additional information below.
* When attempting to diff the file, notice that the filename is URL-encoded--with "+" replaced by "%2B". If you manually edit the URL to contain a plus sign ("+"), the file diff appears as expected.
* You can also open a file before or after the problematic one and click the forward/back links. (This should always be possible because the commit message is always first.)
* File names with plus signs are somewhat common in Objective-C development, where it can be used to denote categories: "ClassName+Category.[h/m]"
Apr 13, 2012
Project Member
#1
bklarson@gmail.com
Nov 28, 2012
Hi, Will be any solution for this issue? Thanks.
Nov 28, 2012
Works for me.
May 9, 2013
Seeing this on the Eclipse Gerrit installation (2.5-1-g9bb651d) with Safari 6 and Google Chrome against the Eclipse Platform UI repository where a large amount of source lives in 'bundles/org.eclipse.ui.workbench/Eclipse UI' Steps: 1. Open https://git.eclipse.org/r/#/c/12673/2 2. Select "Diff All Unified" Note that the java file tabs are empty; the plugin.xml file tab usually works. Reloading the tabs never works. Re-opening 'https://git.eclipse.org/r/#/c/12673/2' and selecting individual files works fine. The URLs are identical.
Jul 2, 2015
Is this still an issue with recent Gerrit versions?
Status:
AwaitingInformation
Jul 6, 2015
I just tested it on current master, no problem with file with a + in the name. Both viewing and editing work OK.
Jul 7, 2015
(No comment was entered for this change.)
Status:
CannotReproduce
|
|
| ► Sign in to add a comment |