My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1246: Mail threading is broken because time stamp accuracy varies
9 people starred this issue and may be notified of changes. Back to list
Status:  CannotReproduce
Owner:  ----
Closed:  Aug 2014


Sign in to add a comment
 
Reported by stefan.f...@genua.de, Jan 31, 2012
Affected Version:
Gerrit 2.1.8
Linux/OpenJDK Runtime Environment (IcedTea6 1.8.7) (6b18-1.8.7-2~squeeze1)
Using MySQL Database backend

What steps will reproduce the problem?

The In-Reply-To and References headers in mails do not match the Message-Id of the initial mail.

What is the expected output? What do you see instead?

Example:

The New change mail has:
Message-ID:  <gerrit.1328012090100.I8be34...>
The comment mails have
In-Reply-To: <gerrit.1328012090000.I8be34...>

Other example:
Message-ID:  <gerrit.1327590027878.Ib5dfa1...
In-Reply-To: <gerrit.1327590027000.Ib5dfa1...

It seems the Change-Creation time stamp is stored with lower accuracy than what is used to create the "new change" mail. The last three digits are always replaced by zeroes in the In-Reply-To header. These should be the same as in the initial mail.

Actually, there is no reason to include a time stamp here. The change number should already be unique, shouldn't it? Or maybe one needs to include the project name, too. If the time stamp is needed, you should make sure that it is actually identical in all the mails.

BTW, it would be more useful to have hierarchical message IDs for different patchsets:

The new change message would get
Message-ID <gerrit.1.Ib5dfa...

The first new patchset message would get
Message-ID <gerrit.2.Ib5dfa...
In-Reply-To <gerrit.1.Ib5dfa...
References <gerrit.1.Ib5dfa...

A comment message on the second patchset would contain
In-Reply-To <gerrit.2.Ib5dfa...
References <gerrit.2.Ib5dfa...>, <gerrit.1.Ib5dfa...>


Aug 25, 2014
Project Member #1 zaro0508
I believe this issue has been fixed.  I tested on gerrit ver 2.8.x and have verified that the email header info for Message-ID, In-Reply-To and References are all identical.

Status: CannotReproduce
Aug 10, 2015
#2 stefan.f...@genua.de
We have recently upgraded to 2.11.2 and this issue is still present. Only the first message (the "new change" mail) has a different ID than all other message.

We use mysql 5.5.44-0+deb7u1 on 32bit linux as backend. Gerrit now runs on a 32bit linux host with

Java version "1.7.0_79"
OpenJDK Runtime Environment (IcedTea 2.5.6) (7u79-2.5.6-1~deb7u1)


Since it is a rounding/accuracy error, it is possible that this issue depends on the host platform or database backend.

Please reset the status to new.
Sign in to add a comment

Powered by Google Project Hosting