| Issue 1241: | rename +2/+1/0/-1/-2 to plain English, the numbers are misleading | |
| 8 people starred this issue and may be notified of changes. | Back to list |
The +2, +1, etc. for reviewing commits is misleading, since it implies that they are summed together, or that math is somehow involved in the process of approval. I've always had to take special care to explain this to new users of Gerrit.
The underlying concept is great, however, and would be better explained with plain english words.
My suggestion:
[approve] Looks good to me, approved
[like] Looks good to me, but someone else must approve
[abstain] I have questions or comments
[dislike] I would prefer that you didn't submit this
[veto] Do not submit
Mar 22, 2012
#1
amir.aha...@mail.huji.ac.il
Mar 22, 2012
For a Gerrit installation this text can be changed in the Gerrit database by updating the corresponding entry in the approval_category_values table.
Mar 22, 2012
how about ‘comments created, expecting to your discuss or a new path set. ’ however I agree with Edwin, this is up to user as it can be customized according user's flavor,need not to change Gerrit code. |
|
| ► Sign in to add a comment |