My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1236: CL with change to file mode only does not show the difference
5 people starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Reported by gkas...@android.com, Jan 19, 2012
Affected Version:

What steps will reproduce the problem?

1. change a file mode with chmod (e.g. +/- the execute bit)
2. upload to Gerrit
3. look at CL in Gerrit

What is the expected output? What do you see instead?

If the only change is to the file mode, Gerrit shows no differences.
It should show the old and new file mode, similar to git diff:
diff --git a/file.c b/file.c
old mode 100755
new mode 100644

Please provide any additional information below.

Apr 23, 2012
#1 bcwal...@gmail.com
I've seen the same problem. It defeats the purpose of having a central code review tool if you have to check out a diff to see the changes locally.
Mar 1, 2013
#2 to...@vackraord.com
Would really like to be able to spot file mode changes in Gerrit. I have accidentally let through patch-sets with file mode changes that was unwanted.
Mar 1, 2013
Project Member #3 edwin.ke...@gmail.com
Can't you see it in the Unified Diff View?
Mar 1, 2013
#4 to...@vackraord.com
nope?
Mar 1, 2013
Project Member #5 edwin.ke...@gmail.com
Which version of Gerrit are you using?
Mar 1, 2013
#6 to...@vackraord.com
2.5.1
Mar 1, 2013
Project Member #7 edwin.ke...@gmail.com
Isn't this the file mode we are talking about?
  http://i.imgur.com/kqiMYwc.png

Mar 1, 2013
#8 to...@vackraord.com
Oh, now I found it in our system also. But jesus, that is subtle and only visible in unified diff on a single file basis... It should almost blink red on the main change view?
Mar 1, 2013
Project Member #9 edwin.ke...@gmail.com
I agree, it should be more obvious, but this is all we have at the moment.
Mar 1, 2013
#10 to...@vackraord.com
Thanks for your help Edwin! Would it be a good idea to post a feature request or is the backlog so big it's pointless?
Mar 1, 2013
Project Member #11 edwin.ke...@gmail.com
It would be good to have it as feature request.

As with any open source project, contributors often have to follow own priorities, so there can't be any promise about how soon this can be implemented, but I think this is definitely a feature that is interesting to others as well.
Sign in to add a comment

Powered by Google Project Hosting