| Issue 1236: | CL with change to file mode only does not show the difference | |
| 5 people starred this issue and may be notified of changes. | Back to list |
Affected Version: What steps will reproduce the problem? 1. change a file mode with chmod (e.g. +/- the execute bit) 2. upload to Gerrit 3. look at CL in Gerrit What is the expected output? What do you see instead? If the only change is to the file mode, Gerrit shows no differences. It should show the old and new file mode, similar to git diff: diff --git a/file.c b/file.c old mode 100755 new mode 100644 Please provide any additional information below.
Apr 23, 2012
#1
bcwal...@gmail.com
Mar 1, 2013
Would really like to be able to spot file mode changes in Gerrit. I have accidentally let through patch-sets with file mode changes that was unwanted.
Mar 1, 2013
Can't you see it in the Unified Diff View?
Mar 1, 2013
nope?
Mar 1, 2013
Which version of Gerrit are you using?
Mar 1, 2013
2.5.1
Mar 1, 2013
Isn't this the file mode we are talking about? http://i.imgur.com/kqiMYwc.png
Mar 1, 2013
Oh, now I found it in our system also. But jesus, that is subtle and only visible in unified diff on a single file basis... It should almost blink red on the main change view?
Mar 1, 2013
I agree, it should be more obvious, but this is all we have at the moment.
Mar 1, 2013
Thanks for your help Edwin! Would it be a good idea to post a feature request or is the backlog so big it's pointless?
Mar 1, 2013
It would be good to have it as feature request. As with any open source project, contributors often have to follow own priorities, so there can't be any promise about how soon this can be implemented, but I think this is definitely a feature that is interesting to others as well. |
|
| ► Sign in to add a comment |