My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1222: File-diff between patch sets doesn't show that file was deleted
2 people starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Project Member Reported by edwin.ke...@gmail.com, Dec 30, 2011
Affected Version: 2.2.1-427-gb43c3b0

What steps will reproduce the problem?
Not sure how to reproduce this but you can see this problem on gerrit-review.googlesource.com:
1. go to https://gerrit-review.googlesource.com/#/c/17380/9 and see that in patch set 9 the file 'gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/CreateProject.java' was deleted and that the same file is contained as modified in the previous patch set
2. open the file diff for this file in patch set 9: https://gerrit-review.googlesource.com/#/c/17380/9/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/CreateProject.java
3. see that the formatting is correct (comparing base with patch set 9)
4. compare patch set 8 and 9 and see that the formatting is now incorrect

What is the expected output? What do you see instead?
When comparing the file between patch set 8 and 9 it is expected that the user can see that this file was deleted in patch set 9 (left side should be formatted in red, right side should be blank). Instead it looks like the file was not changed between patch set 8 and 9.

Please provide any additional information below.
There is also another stange behaviour in this screen. Trying to show the skipped lines does not work (each time when trying to expand the lines before the block, the first line of the file is shown one more time; trying to expand the lines after the block has no effect).
Sign in to add a comment

Powered by Google Project Hosting