My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 119: Side-by-side revision doesn't test for reachable commit SHA-1
  Back to list
Status:  CannotReproduce
Owner:  code-rev...@gtempaccount.com
Closed:  Sep 2009


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Shawn Pearce <sop@google.com> on Mon Mar 30 09:03:22 PDT 2009
Source: JIRA GERRIT-119
Affected Version: 2.0.9

We should validate that the commit SHA-1 requested for diff'ing against in a
side-by-side view is actually a patch set on this change, to avoid users
trying to see changes which have been deleted and aren't reachable anymore by
a ref.
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Wed Apr 15 18:08:19 PDT 2009

This is a non-issue.  The code only processes patch set ids, and it validates
them against the Change.Id.
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Wed Apr 15 18:08:19 PDT 2009
Status: CannotReproduce
Sign in to add a comment

Powered by Google Project Hosting