My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1159: Verified checkmark missing
1 person starred this issue and may be notified of changes. Back to list
Status:  Invalid
Owner:  ----
Closed:  Oct 2011


Sign in to add a comment
 
Reported by jrobert...@gmail.com, Oct 25, 2011
Affected Version: 2.2.1

What steps will reproduce the problem?
1. Have second user upload a patch and assign you as a reviewer.
2. Make sure patch has +1 Verified set.
3. Go to "My Changes" view and note there is no checkmark in V column.

What is the expected output? What do you see instead?

I expect to see a checkmark in the V column for the patch.
When in "All Open" view the patch has a checkmark in the V column. But in the "My Changes" view, where the patch appears in the "Review Requests for [name]" section, the V column is empty.

The <td> element is empty and has no title attribute.

Please provide any additional information below.

The particular patch I'm seeing this defect on currently has Verified +1 and Reviewed -1 scores.
Oct 25, 2011
Project Member #1 bklarson@gmail.com
This is by design.  On the "My Changes" view, you see the score you've given to patches, not the scores others have given (other than for the changes you own).
Status: Invalid
Oct 25, 2011
#2 jrobert...@gmail.com
Okay, thanks for the explanation.

It is a little misleading, because I thought at first the change didn't pass the unit tests (we have the verified bit being set by jenkins).

I don't know what you could aside from cluttering it up by showing both the score from others and the score from me.
Sign in to add a comment

Powered by Google Project Hosting