My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1139: Merged review hanging in Review Requests
5 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  edwin.ke...@gmail.com
Closed:  Nov 2011


Sign in to add a comment
 
Reported by dashkov...@gmail.com, Sep 27, 2011
Affected Version:
2.2.1-234-gac7d2f3

What steps will reproduce the problem?
1. Have any review merged (or abandoned)
2. Add a reviewer into this review 

What is the expected output? What do you see instead?
expected: nothing
see instead: a new reviewer have this review (already MERGED) in Review Requests row in his changes pane. No way to hide this review, it's hanged (and display with bold), and will be for ever.

Please provide any additional information below.
In database this change looks like all other closed reviews.
Sep 29, 2011
#1 dashkov...@gmail.com
After short investigation I found, that in database in table "patch_set_aprovals" field "change_open" is set to Y for closed change, if a reviewer added after change closed.
Sep 30, 2011
Project Member #2 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Accepted
Sep 30, 2011
Project Member #3 edwin.ke...@gmail.com
I will push a fix for this issue as soon as RSAC is available again.
Owner: edwin.ke...@gmail.com
Oct 4, 2011
Project Member #4 edwin.ke...@gmail.com
 Issue 979  has been merged into this issue.
Nov 9, 2011
Project Member #5 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.2.2
Dec 27, 2011
Project Member #6 edwin.ke...@gmail.com
 Issue 1218  has been merged into this issue.
Feb 16, 2012
Project Member #7 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Released
Labels: -FixedIn-2.2.2 FixedIn-2.2.2.1
Sign in to add a comment

Powered by Google Project Hosting