My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1117: Should be able to expand inline comments from code reviews
2 people starred this issue and may be notified of changes. Back to list
Status:  Duplicate
Merged:  issue 93
Owner:  ----
Closed:  Dec 2011


Sign in to add a comment
 
Reported by rspangler@google.com, Aug 29, 2011
Currently, Gerrit shows the following plain text for code reviews with inline comments:

Patch Set 2: (9 inline comments)

(for example, in http://gerrit.chromium.org/gerrit/#change,113)

It'd be really nice if it had a way to expand those comments, or link to them.  Right now, the only workaround is to open the patch set and then open all the files with comments.

Note that the e-mail send by gerrit DOES include the inline comments:

Patch Set 2: (9 inline comments)

....................................................
File host/arch/arm/lib/crossystem_arch.c
Line 13: #include "crossystem_archpm_fw.h"
Should this file be part of the CL?

Line 28: static const GpioMap vb_gpio_map[] = {
Suggest calling this vb_gpio_map_kaen, since it's platform-specific.

...

Sep 21, 2011
#1 nsylv...@chromium.org
(No comment was entered for this change.)
Blocking: chromium:82032
Dec 7, 2011
#2 oswald.b...@gmx.de
duplicates  Issue 93 
Dec 7, 2011
Project Member #3 bklarson@gmail.com
(No comment was entered for this change.)
Status: Duplicate
Mergedinto: 93
May 24, 2013
#4 benhenry@chromium.org
(No comment was entered for this change.)
Blocking: -chromium:82032 chromium:82032 chromium:82032
Sign in to add a comment

Powered by Google Project Hosting