My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1099: User should be able to remove patchsets
17 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  May 2015


Sign in to add a comment
 
Reported by vbendeb@chromium.org, Aug 18, 2011
This is related to https://code.google.com/p/gerrit/issues/detail?id=1097

Say user uploaded a change just to be able to see the side by side diffs, or maybe uploaded a change and noticed a typo in the comments/description. The natural thing to do is to amend the change and upload the update. But this causes two patchsets displayed on the gerrit page, the first patchset is irrelevant, just distracting the reviewer (especially if there were emails generated automatically when the first patch was uploaded).

The user should be able to remove the patchset(s) which he does not intend to be looked at by the reviewers.
Aug 29, 2011
#1 nsylv...@chromium.org
(No comment was entered for this change.)
Blocking: chromium:83654
Apr 25, 2012
#2 msw@chromium.org
I would really like to have this feature (and more feature parity with Reitveld).
Otherwise scratch work or minor incremental updates can cluttering a review.

Having this would allow me to delete unneeded patch sets before pinging reviewers.
Similarly I could delete that mistaken upload that didn't address that one last nit.
Apr 26, 2012
Project Member #3 edwin.ke...@gmail.com
Are you aware of the new drafts feature that was introduced with Gerrit 2.3 [1]?
It allows you to upload a new patch set as a draft by pushing to refs/drafts/<branch-name>. You can inspect the draft patch set in Gerrit and if you don't like it you can delete it. Draft patch sets can be shared with other users by explicitly adding them as reviewer. Once you are satisfied with the patch set you can publish it.

Would this help you?

[1] http://gerrit-documentation.googlecode.com/svn/ReleaseNotes/ReleaseNotes-2.3.html#_drafts
Apr 26, 2012
#4 vben...@google.com
This seems very interesting - is this draft mode supported by the 'repo upload' wrapper?
Apr 30, 2012
#5 vbendeb@chromium.org
Oh well, chromium gerrits are still on 2.1.8....


On Thu, Apr 26, 2012 at 7:49 AM,  <gerrit@googlecode.com> wrote:
May 24, 2013
#6 benhenry@chromium.org
(No comment was entered for this change.)
Blocking: -chromium:83654 chromium:83654 chromium:83654
May 6, 2015
Project Member #7 edwin.ke...@gmail.com
This is supported by the draft workflow [1].

In addition, the force-draft plugin allows admins to reset published patch sets back to draft state, so that they can be deleted [2].

[1] https://gerrit-review.googlesource.com/Documentation/intro-user.html#drafts
[2] https://gerrit-review.googlesource.com/Documentation/config-plugins.html#force-draft
Status: Released
Sign in to add a comment

Powered by Google Project Hosting