My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1082: Gerrit displays ??? instead of Russin letters in comments
4 people starred this issue and may be notified of changes. Back to list
Status:  Duplicate
Merged:  issue 1273
Owner:  ----
Closed:  May 2012


Sign in to add a comment
 
Reported by annu...@gmail.com, Aug 8, 2011
Affected Version: 2.2.1
Aug 8, 2011
#1 sop@google.com
Is the database MySQL?  If so it doesn't have UTF-8 enabled.

Gerrit + MySQL means Unicode doesn't work.  To get proper Unicode support you need to use either PostgreSQL (with the database created with encoding UTF-8) or the embedded H2 database.
Status: AwaitingInformation
Apr 11, 2012
#2 marcin.c...@gmail.com
Yes, we have this with MySQL too.

Example: https://gerrit.wikimedia.org/r/#change,4040

Committer name is sometimes wrong, sometimes right.
Apr 12, 2012
Project Member #3 choro...@wikimedia.org
To have proper Unicode support, shouldn't we just need to specify the collation rather than relying on the defaults (which is probably latin1 for most people)?
Apr 12, 2012
#4 marcin.c...@gmail.com
A patch attached seems to fix the issue for me with MySQL. Database needs to be in the utf-8 encoding already.
0001-Issue-1082-Gerrit-displays-instead-of-UTF-8.patch
1.1 KB   View   Download
Apr 12, 2012
Project Member #5 bklarson@gmail.com
We cannot work with patches attached to the issue tracker.  You must create an account in Gerrit and push your patch there, where it can be reviewed, verified, and merged in.
May 15, 2012
#7 sop@google.com
(No comment was entered for this change.)
Status: Duplicate
Mergedinto: 1273
Sign in to add a comment

Powered by Google Project Hosting